litcli status returns running=true for remote sub-servers that haven't been started

[ViktorTigerstrom]

When litd attempts to connect to a remote sub-server, the connection dialing is non-blocking in this function:

lightning-terminal/subservers/manager.go

Lines 356 to 382 in 601db23

	func dialBackend(name, dialAddr, tlsCertPath string) (*grpc.ClientConn, error) {
	tlsConfig, err := credentials.NewClientTLSFromFile(tlsCertPath, "")
	if err != nil {
	return nil, fmt.Errorf("could not read %s TLS cert %s: %v",
	name, tlsCertPath, err)
	}
	opts := []grpc.DialOption{
	// From the grpcProxy doc: This codec is *crucial* to the
	// functioning of the proxy.
	grpc.WithCodec(grpcProxy.Codec()), // nolint
	grpc.WithTransportCredentials(tlsConfig),
	grpc.WithDefaultCallOptions(maxMsgRecvSize),
	grpc.WithConnectParams(grpc.ConnectParams{
	Backoff: backoff.DefaultConfig,
	MinConnectTimeout: defaultConnectTimeout,
	}),
	}
	log.Infof("Dialing %s gRPC server at %s", name, dialAddr)
	cc, err := grpc.Dial(dialAddr, opts...)
	if err != nil {
	return nil, fmt.Errorf("failed dialing %s backend: %v", name,
	err)
	}
	return cc, nil
	}

As a result, if there is no server running at the specified RPC host, the function does not return an error because the connection status remains as "attempting to connect."

Since the sub-server manager directly sets a remote sub-server as running=true if the function does not return an error, the sub-server is marked as running here:

lightning-terminal/subservers/manager.go

Lines 134 to 141 in 601db23

	err := ss.connectRemote()
	if err != nil {
	s.statusServer.SetErrored(ss.Name(), err.Error())
	continue
	}
	s.statusServer.SetRunning(ss.Name())
	}

[ellemouton]

@ViktorTigerstrom - do you have a solution in mind & can this be assigned to you?

Perhaps some call-back on the first successful connection of some sort?

[ViktorTigerstrom]

Let's assign this to me :)!

Perhaps some call-back on the first successful connection of some sort?

Yeah, i'll experiment a bit with that and determine best solution.