Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcmiddleware: propagate certain context values across grpc #933

Open
ellemouton opened this issue Jan 14, 2025 · 0 comments
Open

rpcmiddleware: propagate certain context values across grpc #933

ellemouton opened this issue Jan 14, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@ellemouton
Copy link
Member

Opening the general tracking issue here although most of the work will probably take place in LND and LND client.

Feature description

Today in LiT, if we have a request coming through LNC, we can intercept it there before it gets sent
to any of the interceptors registered with the LND RPC middleware interceptor. This can be useful
for adding the LNC session's ID to the context of the incoming request. That way the Action Logger
interceptor should, for example, be able to extract the session ID from the incoming context. This,
however, does not work today since the RPC middleware interception management happens over gRPC
which does not propagate context values by default. We should be able to make use of gRPC metadata
to transmit certain context values (at least those that have a String() method).

@ellemouton ellemouton added the enhancement New feature or request label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant