[bug]: force Private=false for regular invoices like is done for hold invoices.

[ZZiigguurraatt]

At

taproot-assets/rpcserver.go

Lines 7277 to 7279 in 77e8b28

	// We set private to false as we don't want to
	// add any hop hints other than this one.
	Private: false,

we force private to false for hold invoices as we want to ensure that only a single hop hint is provided for a single private taproot assets channel (which overrides any other hop hints that may be defined).

This is not done for regular invoices though and should be so that we don't accidentally also issue route hints for channels and assets that we don't actually want to receive on.

I'm guessing we need to add

iReq.Private=false

after

taproot-assets/rpcserver.go

Line 7297 in 77e8b28

// Otherwise, we'll make this into a normal invoice.

but I'm not a go programmer, so not sure of the exact syntax.

[Roasbeef]

With the way Go works, default values are implicit. I set False above to call out that behavior explicitly to the reader.

Later on we made a follow up PR to fix a bug that was being masked by an incomplete feature: lightninglabs/lndclient#204.

The second section you posted uses the low level RPC API, which inherits the same default semantics. As a result, the Private field is already false.