You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Given the Skip checks demonstrated in #1192, in situ RFQ testing requires exceptions for integration tests due to an inability to properly set up asset channels within exclusively the tapd code base. Ergo, flags like SkipAssetChannelCheck are a temporarily solution but they relax the validation certainty.
Describe the solution you'd like
Introduce a lnd-mock that will mimic asset channels, allowing tapd to test in a more accurate way without depending on validation-exemption flags.
Testing improvements, Easier test-code creation
The proposed mock could be used to test other features of tapd that currently rely on real lnd instances.
Describe alternatives you've considered
Continue using the validation-exemption flags testing setup s.a. SkipAssetChannelCheck flag, but this approach has limitations as we can't fully test the asset channel validation logic.
Is your feature request related to a problem? Please describe.
Given the
Skip
checks demonstrated in #1192, in situ RFQ testing requires exceptions for integration tests due to an inability to properly set up asset channels within exclusively the tapd code base. Ergo, flags likeSkipAssetChannelCheck
are a temporarily solution but they relax the validation certainty.Describe the solution you'd like
Introduce a lnd-mock that will mimic asset channels, allowing tapd to test in a more accurate way without depending on validation-exemption flags.
Testing improvements, Easier test-code creation
The proposed mock could be used to test other features of tapd that currently rely on real lnd instances.
Describe alternatives you've considered
Continue using the validation-exemption flags testing setup s.a.
SkipAssetChannelCheck
flag, but this approach has limitations as we can't fully test the asset channel validation logic.Related issues
AddAssetBuyOrder
andAddAssetSellOrder
RPCs #1192 - [rfq]: add validation to AddAssetBuyOrder and AddAssetSellOrder RPCsAddAssetBuyOrder
andAddAssetSellOrder
RPCs #1192The text was updated successfully, but these errors were encountered: