Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Add lnd mock to mimick asset channel actions in order to improve testing #1212

Open
dstadulis opened this issue Nov 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@dstadulis
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Given the Skip checks demonstrated in #1192, in situ RFQ testing requires exceptions for integration tests due to an inability to properly set up asset channels within exclusively the tapd code base. Ergo, flags like SkipAssetChannelCheck are a temporarily solution but they relax the validation certainty.

Describe the solution you'd like

Introduce a lnd-mock that will mimic asset channels, allowing tapd to test in a more accurate way without depending on validation-exemption flags.

Testing improvements, Easier test-code creation

The proposed mock could be used to test other features of tapd that currently rely on real lnd instances.

Describe alternatives you've considered

Continue using the validation-exemption flags testing setup s.a. SkipAssetChannelCheck flag, but this approach has limitations as we can't fully test the asset channel validation logic.

Related issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant