Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link level bidirectional strict-forwarding #1247

Closed
1 of 2 tasks
GeorgeTsagk opened this issue Dec 10, 2024 · 1 comment
Closed
1 of 2 tasks

Link level bidirectional strict-forwarding #1247

GeorgeTsagk opened this issue Dec 10, 2024 · 1 comment

Comments

@GeorgeTsagk
Copy link
Member

GeorgeTsagk commented Dec 10, 2024

Description

A node that creates an invoice with the intention of receiving asset type X will want to settle invoice only if the HTLCs paying to it carry units of asset type X.

In our last iteration we added a guard to the AuxInvoiceManager which prohibits asset invoices being settled by HTLCs carrying pure btc (see related PR, and specific code section)

Problem

While this is partially effective, we still have a few open vectors:

  • A btc invoice may still be paid for with HTLCs carrying assets
  • An asset invoice may not be settled by btc HTLCs, but it may be settled by HTLCs carrying assets of a different type

Proposed Solution

@GeorgeTsagk GeorgeTsagk self-assigned this Dec 10, 2024
@dstadulis dstadulis moved this from 🆕 New to 🔖 Ready in Taproot-Assets Project Board Dec 10, 2024
@dstadulis dstadulis added this to the v0.5 milestone Dec 10, 2024
@dstadulis dstadulis moved this from 🔖 Ready to 🏗 In progress in Taproot-Assets Project Board Dec 10, 2024
@dstadulis dstadulis moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Dec 12, 2024
@dstadulis
Copy link
Collaborator

Closing as strict forwarding was delivered which was necessary for v0.5

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Taproot-Assets Project Board Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants