Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: tapcli assets mint finalize returns "new_grouped_asset": false for new grouped asset #1280

Open
gijswijs opened this issue Jan 8, 2025 · 0 comments
Labels
bug Something isn't working needs triage

Comments

@gijswijs
Copy link
Contributor

gijswijs commented Jan 8, 2025

Background

When minting a new grouped asset, the initial minting command returns the asset inside the pending_batch with "new_grouped_asset": true but upon finalizing the batch the asset is identified as being not a new grouped asset ( "new_grouped_asset": false)

Your environment

  • lnd v0.18.4-beta
  • tapd v0.5.0-alpha
  • bitcoind v28.0

Steps to reproduce

tap@alice-tap:/$ tapcli assets mint --type normal --name florin1 --supply 1000000 --decimal_display 3 --meta_b
ytes '{"hello":true}' --meta_type json --new_grouped_asset
{
    "pending_batch":  {
        "batch_key":  "03fde3a46e100970ead7abf88f99cc7e6fe685d7af83c3a26a9362a551a5e612a9",
        "batch_txid":  "",
        "state":  "BATCH_STATE_PENDING",
        "assets":  [
            {
                "asset_version":  "ASSET_VERSION_V0",
                "asset_type":  "NORMAL",
                "name":  "florin1",
                "asset_meta":  {
                    "data":  "7b22646563696d616c5f646973706c6179223a332c2268656c6c6f223a747275657d",
                    "type":  "META_TYPE_JSON",
                    "meta_hash":  "1b206639244dae9875be0db3babd9c326e9ffe319f9a913c56b765c8e80b6299"
                },
                "amount":  "1000000",
                "new_grouped_asset":  true,
                "group_key":  "",
                "group_anchor":  "",
                "group_internal_key":  {
                    "raw_key_bytes":  "02d4de6e158788a0a9978aa8c7b5bcc9fe912d34c998520ca4ffb56862284fff72",
                    "key_loc":  {
                        "key_family":  212,
                        "key_index":  9
                    }
                },
                "group_tapscript_root":  "",
                "script_key":  {
                    "pub_key":  "14427e26f0f858a323a71bcbc4805c8533c7eb8e5a359dc5ffdbe6f9a7afd511",
                    "key_desc":  {
                        "raw_key_bytes":  "0262c9922d1b370353bccd0df11b9d640bc1242eeeb6472c967ebf799791604a60",
                        "key_loc":  {
                            "key_family":  212,
                            "key_index":  10
                        }
                    },
                    "tap_tweak":  ""
                }
            }
        ],
        "created_at":  "1736348208",
        "height_hint":  120,
        "batch_psbt":  ""
    }
}
tap@alice-tap:/$ tapcli assets mint finalize
{
    "batch":  {
        "batch_key":  "03fde3a46e100970ead7abf88f99cc7e6fe685d7af83c3a26a9362a551a5e612a9",
        "batch_txid":  "9075187d117ab2d7784e82b3913c0755285fc6e2859b8e129a0f0993e3c05ac8",
        "state":  "BATCH_STATE_BROADCAST",
        "assets":  [
            {
                "asset_version":  "ASSET_VERSION_V0",
                "asset_type":  "NORMAL",
                "name":  "florin1",
                "asset_meta":  {
                    "data":  "7b22646563696d616c5f646973706c6179223a332c2268656c6c6f223a747275657d",
                    "type":  "META_TYPE_JSON",
                    "meta_hash":  "1b206639244dae9875be0db3babd9c326e9ffe319f9a913c56b765c8e80b6299"
                },
                "amount":  "1000000",
                "new_grouped_asset":  false,
                "group_key":  "0248b023815660da00cb73910be25f5b607f2de464d0b883f8676fcbfe23f18551",
                "group_anchor":  "",
                "group_internal_key":  {
                    "raw_key_bytes":  "02d4de6e158788a0a9978aa8c7b5bcc9fe912d34c998520ca4ffb56862284fff72",
                    "key_loc":  {
                        "key_family":  212,
                        "key_index":  9
                    }
                },
                "group_tapscript_root":  "",
                "script_key":  {
                    "pub_key":  "14427e26f0f858a323a71bcbc4805c8533c7eb8e5a359dc5ffdbe6f9a7afd511",
                    "key_desc":  {
                        "raw_key_bytes":  "0262c9922d1b370353bccd0df11b9d640bc1242eeeb6472c967ebf799791604a60",
                        "key_loc":  {
                            "key_family":  212,
                            "key_index":  10
                        }
                    },
                    "tap_tweak":  ""
                }
            }
        ],
        "created_at":  "1736348208",
        "height_hint":  120,
        "batch_psbt":  "70736274ff0100890200000001679049b1ac22313afd810d6c639340cd4838e42e4468be8a86aed94ee7c5ed0101000000000000000002e803000000000000225120eb1ac6125a146a6d7d28c095733b4e88cd6dfd35f13e8447ffa75d4edce4c7e933da0e0000000000225120fe2b58aa1f7fd90ee2d299ff4b83ca2f01853cf4c10d938d5fa94add9b5f4553000000000001012b2ffc0e00000000002251200fc2763ceb37d5d17544300c8af05d2d8f9161b75aea7c489d63a0872e12202e0108420140621cea721ae2308969d73bd218fa51c920cd95b10f54a69b26a3c6d3e9debd849cbce4cd3287d24ce041f9905fc5605f2ca7b19a9bbe604c3730180f0f3b8c65000022020370c7977e8754707666cd0ba106b8a098244a74f267ad51f5f06e62ec3db53e641800000000560000800000008000000080010000000200000001052070c7977e8754707666cd0ba106b8a098244a74f267ad51f5f06e62ec3db53e64210770c7977e8754707666cd0ba106b8a098244a74f267ad51f5f06e62ec3db53e64190000000000560000800000008000000080010000000200000000"
    }
}

Expected behavior

Upon finalizing the asset should be identified with "new_grouped_asset": true

Actual behavior

The asset should is identified with "new_grouped_asset": false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant