-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: add asset metadata to unsigned minting group virtual PSBT #1298
Comments
We might want to run this by hardware wallet builders, see what they might to have included as metadata. Do we need a timestamp to aid in record keeping? |
Is it guaranteed that the metadata will be returned back in the signed PSBT? Seems like the signer has some freedom to remove that kind of information from the PSBT? |
Yes, according to the PSBT BIP some fields should be removed after adding the signature (or better the final signature, so all signers still see the metadata until the final one constructs the final witness). |
Well, I guess I was wondering if the asset ID could be passed along to the final PSBT, then with #1295 the asset ID could be decoded automatically and then the user would not need to pass the assetid when sealing the batch. Since the metadata can be removed from the PSBT once the final signature is added, it seems there is no way to avoid the need for the user to pass the asset ID when sealing the batch? |
This PR introduces support for asset group key signatures using an external key during asset minting: #1272.
To enhance functionality, the unsigned PSBT generated during the minting process should include additional asset metadata, such as:
This enrichment would allow external signing software to display helpful asset metadata, providing more transparency and usability during the signing process.
We can add arbitrary fields to
psbt.Packet.Unknowns
.Shaping TODO
We need additional shaping on the following:
Value
for these fields as bytes.Value
field encoding needs to be easy for hardware signers to decode.The text was updated successfully, but these errors were encountered: