Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3/8.4 support #92

Closed
beryllium opened this issue Nov 26, 2024 · 3 comments
Closed

PHP 8.3/8.4 support #92

beryllium opened this issue Nov 26, 2024 · 3 comments

Comments

@beryllium
Copy link
Contributor

Hello there, and thank you for writing this library! I'm a backend developer at SmugMug, and I've been finding this library useful for a tool I've been writing that talks to SmugMug's API.

I've noticed that Guzzle 6 has some internal logic that consistently triggers a noisy E_DEPRECATED notice in PHP 8.3/8.4.

I think the path forward would be to upgrade the library to use Guzzle 7.5+. I would also suggest updating composer.json to require at least PHP 8.1, and phpunit 10 or 11, as well as updating the way code sniffing is applied.

Would you be open to having me start some PRs for those changes? If you have another approach in mind, I'm happy to discuss things.

@lildude
Copy link
Owner

lildude commented Nov 26, 2024

Would you be open to having me start some PRs for those changes?

Definitely. I've been meaning to find some time to update things like this (and move dev into a container) but time is like hen's teeth these days.

@lildude
Copy link
Owner

lildude commented Jan 22, 2025

A lot of dependencies have now been updated so things should hopefully work without issue on PHP 8.3 and 8.4 now.

@lildude lildude closed this as completed Jan 22, 2025
@lildude
Copy link
Owner

lildude commented Jan 22, 2025

Oh yes. I'll tag a new version later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants