Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding credentials file support #157

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Adding credentials file support #157

merged 1 commit into from
Jan 13, 2025

Conversation

mtauraso
Copy link
Collaborator

Simple support for a credentials.ini file with documentation

@mtauraso mtauraso linked an issue Jan 10, 2025 that may be closed by this pull request
Get username/passwords in a way that doesn't end up in a repo #69
Closed
@mtauraso mtauraso requested a review from drewoldag January 10, 2025 23:47
@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 39.34%. Comparing base (9d1fb12) to head (73a24b4).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/fibad/download.py 5.00% 19 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   39.63%   39.34%   -0.29%     
==========================================
  Files          23       23              
  Lines        1847     1863      +16     
==========================================
+ Hits          732      733       +1     
- Misses       1115     1130      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Before [9d1fb12] After [bddaf05] Ratio Benchmark (Parameter)
2.26±0.6s 2.85±1s ~1.26 benchmarks.time_computation
904 1.13k 1.25 benchmarks.mem_list

Click here to view all benchmarks.

drewoldag
drewoldag approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@drewoldag drewoldag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right path forward to me. Thanks for putting it together.

@mtauraso mtauraso merged commit 9ee75ce into main Jan 13, 2025
6 of 8 checks passed
@mtauraso mtauraso deleted the issue/69/nice-credential-handling branch January 13, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewoldag drewoldag drewoldag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get username/passwords in a way that doesn't end up in a repo
2 participants
@mtauraso @drewoldag