Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region crop for absolute values #23

Open
danielpes opened this issue Jul 12, 2012 · 0 comments
Open

Region crop for absolute values #23

danielpes opened this issue Jul 12, 2012 · 0 comments

Comments

@danielpes
Copy link
Contributor

If there is a defined region with any size, and a media is associated to this region but with a new absolute size (defined by property tags) bigger than the parent region, the player does not crop the media to the size of the parent region (even if the parent region has the same size of the canvas!).

Example: http://pastebin.com/LVbM5CN6

Even though the Ginga-NCL player does crop the media in this case (the blue jpg is shown with the size of 'parent' region, which is 90% of the canvas size), we decided to keep the media with the size defined by the user, since it is an absolute value.

Suggestion: show a warning when the user choose a size for a media that is bigger than the parent region of the region referred by the media.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant