Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unable to set timer reminder in Linglong environment #184

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

myml
Copy link
Member

@myml myml commented Aug 8, 2024

玲珑环境会将家目录config进行隔离, 无法在此创建systemd服务
检测玲珑环境并修正config路径位置

Log:

玲珑环境会将家目录config进行隔离, 无法在此创建systemd服务
检测玲珑环境并修正config路径位置

Log:
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 8, 2024

TAG Bot

TAG: 5.14.4
EXISTED: no
DISTRIBUTION: unstable

发布1.5.4版本

Log: 修复玲珑环境没有日程提醒
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增的代码中,使用了qgetenv来获取环境变量LINGLONG_APPID,但没有检查环境变量的存在性,可能会导致未处理的初始化路径。
  • 新增代码中使用了mkpath来创建路径,但没有检查路径是否已经存在,可能会导致重复的文件夹创建。
  • 新增的环境变量LINGLONG_APPID可能需要文档说明其用途和行为。

是否建议立即修改:

@myml
Copy link
Member Author

myml commented Aug 8, 2024

/integrate

Copy link

github-actions bot commented Aug 8, 2024

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#1858
PrNumber: 1858
PrBranch: auto-integration-10295510274

@@ -6,6 +6,7 @@

#include "commondef.h"
#include "units.h"
#include <qloggingcategory.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <qloggingcategory.h>
#include <QLoggingCategory>

以及位置和下面的挪到一起?

Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myml 沟通确认,前述问题“在下个提交有改”

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, myml

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myml myml merged commit a3d8e1a into linuxdeepin:master Aug 14, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants