Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release 1.5.5 #185

Merged
merged 4 commits into from
Sep 4, 2024
Merged

chore: Release 1.5.5 #185

merged 4 commits into from
Sep 4, 2024

Conversation

myml added 4 commits August 14, 2024 16:39
修复侧边栏日历组件的显示

Log:
Issues: linuxdeepin/developer-center#10343
在更改systemd配置后应该执行daemon-reload

Log:
Issues: linuxdeepin/developer-center#10093
修复悬浮框显示位置问题

Log:
Issues: linuxdeepin/developer-center#10341
发布1.5.5版本

Log: 修复日历提示框显示问题
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • slotScheduleRemindWidget函数中,使用rPos.x() < this->window()->width() / 2来决定箭头方向可能会导致逻辑错误,因为rPos.x()是相对于窗口的坐标,而this->window()->width() / 2是相对于屏幕的坐标。建议使用rPos.x() < this->window()->geometry().x() + this->window()->width() / 2来确保逻辑正确。
  • slotMousePress函数中,使用qCDebug(ServiceLogger) << "updateRemind" << "list size:" << remindList.size();来打印调试信息,但没有考虑到remindList.size()为0的情况,可能会导致除以零的错误。建议在打印信息之前先检查列表是否为空。
  • CSystemdTimerControl::buildingConfiggure函数中,使用qCDebug(ServiceLogger) << "exec: " << command << "output: " << strResult;来打印执行命令的输出,但没有考虑到strResult为空的情况,可能会导致空指针解引用。建议在打印信息之前先检查输出是否为空。
  • execLinuxCommand函数中,使用qCDebug(ServiceLogger)来打印调试信息,但没有考虑到command为空的情况,可能会导致空指针解引用。建议在打印信息之前先检查命令是否为空。

是否建议立即修改:

Copy link

TAG Bot

TAG: 5.14.5
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, myml

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myml
Copy link
Member Author

myml commented Aug 14, 2024

/integrate

Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#1887
PrNumber: 1887
PrBranch: auto-integration-10384353877

@myml myml merged commit 3d7cb04 into linuxdeepin:master Sep 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants