fix deprecated warnings and adjust function calls #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
单参数的QProcess::startDetached已弃用, 使用双参数的函数替换
使用DPaletteHelper和DGuiApplicationHelper替换已标记弃用的DApplicationHelper
使用startOfDay替换已标记弃用的构造函数
toSet已标记弃用
buttonClicked已标记弃用
setAutoCompletion已标记弃用
DHiDPIHelper已标记弃用
activated已标记弃用
orientation已标记弃用
delta已标记弃用
QString::SkipEmptyParts已标记弃用
QFontMetrics.width已标记弃用
|
Note
详情{
"calendar-client/src/main.cpp": [
{
"line": " app->setApplicationAcknowledgementPage(\"https://www.deepin.org/acknowledgments/dde-calendar\");",
"line_number": 67,
"rule": "S35",
"reason": "Url link | f82e0b7f80"
}
],
"calendar-client/src/widget/calendarmainwindow.cpp": [
{
"line": " url = \"https://www.deepin.org/zh/agreement/privacy/\";",
"line_number": 906,
"rule": "S35",
"reason": "Url link | 20e2eab189"
},
{
"line": " url = \"https://www.uniontech.com/agreement/privacy-cn\";",
"line_number": 908,
"rule": "S35",
"reason": "Url link | 4850a00dd7"
},
{
"line": " url = \"https://www.deepin.org/en/agreement/privacy/\";",
"line_number": 912,
"rule": "S35",
"reason": "Url link | 38d42f63bf"
},
{
"line": " url = \"https://www.uniontech.com/agreement/privacy-en\";",
"line_number": 914,
"rule": "S35",
"reason": "Url link | f82409d3b5"
}
]
} |
BLumia
reviewed
Nov 16, 2024
| @@ -10,7 +10,7 @@ | |||
| #include "cscheduleoperation.h" | |||
| #include "lunarmanager.h" | |||
|
|
|||
| #include <DHiDPIHelper> | |||
|
|
|||
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| #include <DMessageBox> | |||
| #include <DPushButton> | |||
| #include <DHiDPIHelper> | |||
|
|
|||
| @@ -14,7 +14,7 @@ | |||
| #include "units.h" | |||
| #include "commondef.h" | |||
|
|
|||
| #include <DHiDPIHelper> | |||
|
|
|||
| @@ -11,7 +11,7 @@ | |||
| #include "constants.h" | |||
| #include "scheduledaterangeinfo.h" | |||
|
|
|||
| #include <DHiDPIHelper> | |||
|
|
|||
| @@ -324,7 +324,7 @@ void CAllDayEventWeekView::mouseDoubleClickEvent(QMouseEvent *event) | |||
| void CAllDayEventWeekView::wheelEvent(QWheelEvent *event) | |||
| { | |||
| //若滚轮事件为左右方向则退出 | |||
| if (event->orientation() == Qt::Orientation::Horizontal) { | |||
| if (event->angleDelta().x() != 0 ) { | |||
There was a problem hiding this comment.
Suggested change
| if (event->angleDelta().x() != 0 ) { | |
| if (event->angleDelta().x() != 0) { |
| @@ -29,12 +29,11 @@ | |||
| #include "units.h" | |||
| #include "commondef.h" | |||
|
|
|||
| #include <DHiDPIHelper> | |||
|
|
|||
解决多个警告的小问题
|
Note
详情{
"calendar-client/src/main.cpp": [
{
"line": " app->setApplicationAcknowledgementPage(\"https://www.deepin.org/acknowledgments/dde-calendar\");",
"line_number": 67,
"rule": "S35",
"reason": "Url link | f82e0b7f80"
}
],
"calendar-client/src/widget/calendarmainwindow.cpp": [
{
"line": " url = \"https://www.deepin.org/zh/agreement/privacy/\";",
"line_number": 906,
"rule": "S35",
"reason": "Url link | 20e2eab189"
},
{
"line": " url = \"https://www.uniontech.com/agreement/privacy-cn\";",
"line_number": 908,
"rule": "S35",
"reason": "Url link | 4850a00dd7"
},
{
"line": " url = \"https://www.deepin.org/en/agreement/privacy/\";",
"line_number": 912,
"rule": "S35",
"reason": "Url link | 38d42f63bf"
},
{
"line": " url = \"https://www.uniontech.com/agreement/privacy-en\";",
"line_number": 914,
"rule": "S35",
"reason": "Url link | f82409d3b5"
}
]
} |
BLumia
approved these changes
Nov 16, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BLumia, myml The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解决所有弃用警告，为适配Qt6做准备