Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: QT6.8 adaptation #130

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

pengfeixx
Copy link
Contributor

QT6.8 adaptation

Log: QT6.8 adaptation

QT6.8 adaptation

Log: QT6.8 adaptation
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. 依赖库版本更新

    • debian/control文件中,将libdtkwidget-devlibdtkgui-dev更新为libdtk6widget-devlibdtk6gui-dev,以及将qttools5-dev-tools更新为qt6-tools-dev-toolslibqt5svg5-dev更新为qt6-svg-dev。需要确认这些库的版本更新是否与项目兼容,并且是否已经测试过这些更新后的库。
  2. 测试用例删除

    • ut_dfdeletedialog.cpp文件中,删除了checkConnect测试用例。如果这个测试用例不再需要,那么删除是合理的。如果这个测试用例是必要的,那么应该保留并确保其功能正确。
  3. 注释掉的代码

    • ut_dfontmgrmainwindow.cpp文件中,注释掉了showFontFilePostion方法的测试代码。如果这部分代码不再需要,那么注释掉是合理的。如果这部分代码是必要的,那么应该移除注释并确保其功能正确。
  4. 新增头文件

    • ut_dfontmgrmainwindow.cpp文件中,新增了<QMimeData><QStorageInfo>头文件。需要确认这些头文件是否真的需要,以及它们是否与项目中的其他部分兼容。
  5. 未使用的宏

    • ut_dfontmgrmainwindow.cpp文件中,ADDR(DDesktopServices, showFileItem)宏被注释掉了,但没有移除。如果这个宏不再使用,应该将其移除以保持代码的整洁。
  6. 测试用例的健壮性

    • ut_dfdeletedialog.cpp文件中的checkConnect测试用例中,连续点击m_confirmBtn两次,这可能会导致测试不稳定。建议添加一些延迟或使用循环来确保测试的稳定性。
  7. 代码注释

    • ut_dfontmgrmainwindow.cpp文件中,// s1.set(FP ADDR(DDesktopServices, showFileItem), stub_return);这行代码的注释应该更详细,说明为什么这行代码被注释掉,以及它原本的功能。

总的来说,代码的更新和测试用例的调整需要确保与项目的整体架构和测试策略保持一致。同时,注释掉或删除的代码应该有充分的理由,并且应该确保这些更改不会影响项目的其他部分。

Copy link
Contributor

@myk1343 myk1343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: myk1343, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx pengfeixx merged commit 0158c56 into linuxdeepin:develop/qt6.8 Jan 9, 2025
15 of 17 checks passed
@pengfeixx pengfeixx deleted the qt6.8 branch January 9, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants