Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 通过dconfig屏蔽进程暂停与恢复进程功能 #365

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

myk1343
Copy link
Contributor

@myk1343 myk1343 commented Sep 6, 2024

通过dconfig屏蔽进程暂停与恢复进程功能

Bug: https://pms.uniontech.com/bug-view-272331.html
Log: 通过dconfig屏蔽进程暂停与恢复进程功能

通过dconfig屏蔽进程暂停与恢复进程功能

Bug: https://pms.uniontech.com/bug-view-272331.html
Log: 通过dconfig屏蔽进程暂停与恢复进程功能
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • ProcessTableView::initConnections函数中,直接修改了resumeProcActionpauseProcAction的可见性,这可能会影响用户界面的交互。建议使用更优雅的方式来处理配置的加载和显示逻辑。
  • 代码中没有处理config对象可能为nullptr的情况,这可能会导致在尝试访问config->value时引发异常。
  • 变量varMenu被声明但未使用,应该移除未使用的变量以提高代码清晰度。

是否建议立即修改:

@jeffshuai
Copy link

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: max-lvs, myk1343

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@myk1343
Copy link
Contributor Author

myk1343 commented Sep 6, 2024

/merge

@deepin-bot deepin-bot bot merged commit 2d70563 into linuxdeepin:release/eagle Sep 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants