Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fail to kill linglong app #379

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

wangrong1069
Copy link
Contributor

Previously, when killing an application, system-monitor needed to obtain the pid of the app. However, on a desktop environment using X11, system-monitor obtained an inaccurate pid of the linglong app, which resulted in failure to kill the app or accidental killing. Now consider using the window manager to kill the application, because the window manager contains detailed information about the application window.

Log: fix fail to kill linglong app
Bug: https://pms.uniontech.com/bug-view-283189.html

Previously, when killing an application, system-monitor needed to
obtain the pid of the app. However, on a desktop environment using X11,
system-monitor obtained an inaccurate pid of the linglong app, which
resulted in failure to kill the app or accidental killing. Now consider
using the window manager to kill the application, because the window
manager contains detailed information about the application window.

Log: fix fail to kill linglong app
Bug: https://pms.uniontech.com/bug-view-283189.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • MainWindow::initUI函数中,killAction的添加被移动到了条件判断内部,这可能导致killActionorg.kde.KWin服务未注册时未被添加到菜单中。
  • ProcessPageWidget::initConnections函数中,showWindowKiller连接被注释掉了,如果这是有意为之,应该添加注释说明原因。

是否建议立即修改:

  • 是,需要确保killAction在所有情况下都能被正确添加到菜单中,并且需要解释为什么showWindowKiller连接被注释掉。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangrong1069
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit fde8fa7 into linuxdeepin:master Nov 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants