Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add close.dci #248

Merged
merged 1 commit into from
Jul 26, 2024
Merged

feat: add close.dci #248

merged 1 commit into from
Jul 26, 2024

Conversation

asterwyx
Copy link
Contributor

Add close.dci as builtin icon.

Add close.dci as builtin icon.
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jul 25, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#248
deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Jul 25, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#248
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • deepin-theme-plugin-icons.qrc文件中新增了一个<file>标签来引用close.dci文件,需要确认这个文件是否已经定义在项目中。

是否建议立即修改:

  • 是,如果close.dci文件没有在项目中定义,那么这个提交可能会导致编译错误或运行时错误。需要确保新增的文件路径是正确的,并且文件已经被正确地包含在构建过程中。

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 25, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@asterwyx asterwyx requested a review from kegechen July 26, 2024 02:10
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@asterwyx asterwyx merged commit 12b60a3 into linuxdeepin:master Jul 26, 2024
16 of 17 checks passed
@asterwyx asterwyx deleted the icons branch July 26, 2024 03:01
asterwyx pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Jul 26, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants