Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add window startup effect Type #250

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

xionglinlin
Copy link
Contributor

add EffectOut to EffectType

Issue: linuxdeepin/developer-center#10322

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • DPlatformHandle类中新增了一个枚举值EffectOut,但未看到对应的使用场景和功能实现。
  • 枚举EffectBottom的注释已更新,但未看到代码中其他部分是否有相应的修改或支持。

是否建议立即修改:

  • 是,需要确保新增的枚举值EffectOut有相应的功能实现和文档说明,并且与代码库的其他部分保持一致。
  • 是,需要确保枚举值的注释和实际功能相匹配,避免混淆和误解。

deepin-ci-robot added a commit to linuxdeepin/dtk6gui that referenced this pull request Aug 13, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#250
@xionglinlin
Copy link
Contributor Author

/review @18202781743

@github-actions github-actions bot requested a review from 18202781743 August 13, 2024 12:12
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 13, 2024

Doc Check bot
🟡 some documents missing!

File Line Symbol
include/kernel/dplatformhandle.h 102 static bool Dtk::Gui::DPlatformHandle::setWindowBlurAreaByWM

@xionglinlin
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 13, 2024

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit 75ce762 into linuxdeepin:master Aug 13, 2024
18 of 21 checks passed
18202781743 pushed a commit to linuxdeepin/dtk6gui that referenced this pull request Aug 14, 2024
Synchronize source files from linuxdeepin/dtkgui.

Source-pull-request: linuxdeepin/dtkgui#250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants