fix: DApplication初始化过程中会覆盖原有事件掩码，导致丢失事件 #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 8, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
|
Doc Check bot |
|
commit 信息组织一下，dtkwidget 毕竟不是仅仅给控制中心使用的。 可以从原理角度描述一下bug，最后附上bug连接 |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 8, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
zccrs
requested changes
Nov 9, 2023
src/widgets/private/startupnotifications/startupnotificationmonitor.cpp
Outdated
Show resolved
Hide resolved
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 9, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
LiHua000
changed the title
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 9, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 9, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 9, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
zccrs
requested changes
Nov 9, 2023
src/widgets/private/startupnotifications/startupnotificationmonitor.cpp
Outdated
Show resolved
Hide resolved
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 9, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 9, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 9, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 9, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 9, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
zccrs
previously approved these changes
Nov 9, 2023
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 9, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
|
/merge |
|
This pr cannot be merged! (status: blocked) |
|
/check obs |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 10, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
|
/check obs |
|
Deepin Obs Bot |
|
commit信息主体前面的尾注Log删一下 |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 13, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
DApplication应用初始化时通过设置xcb窗口属性，设置了XCB_EVENT_MASK_PROPERTY_CHANGE事件掩码，此时Xorg会对发送给客户端的事件根据事件掩码来过滤，例如关闭文件选择对话框时发送的类型为focusIn的clientMessageEvent就不会发送给客户端。修改为先判断当前事件掩码是否含有XCB_EVENT_MASK_PROPERTY_CHANGE掩码，有的话不进行处理，没有的话在原有掩码上追加该掩码 Bug: https://pms.uniontech.com/bug-view-220369.html
deepin-ci-robot
added a commit
to linuxdeepin/dtk6widget
that referenced
this pull request
Nov 13, 2023
Synchronize source files from linuxdeepin/dtkwidget. Source-pull-request: linuxdeepin/dtkwidget#535
kegechen
approved these changes
Nov 13, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kegechen, LiHua000 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log:DApplication应用初始化时通过设置xcb窗口属性，设置了XCB_EVENT_MASK_PROPERTY_CHANGE事件掩码，此时Xorg会对发送给客户端的事件根据事件掩码来过滤，例如关闭文件选择对话框时发送的类型为focusIn的clientMessageEvent就不会发送给客户端。虽然在关闭对话框时，XOrg也会发送一次FocusIn底层事件，但这个事件和窗口的关闭信号有时序上的问题，所以真正重要的是前面所说的clientMessageEvent。故添加事件掩码以获取对应事件。
Bug: https://pms.uniontech.com/bug-view-220369.html