Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratings: unify voting/like terminology across aplus & mB #1673

Open
hom3mad3 opened this issue Aug 27, 2024 · 4 comments
Open

Ratings: unify voting/like terminology across aplus & mB #1673

hom3mad3 opened this issue Aug 27, 2024 · 4 comments
Labels
Dev: Frontend Dev: Refactor issues to be fixed with code refactor Status: Decision Needed Issues that are blocked because decision is needed

Comments

@hom3mad3
Copy link
Contributor

hom3mad3 commented Aug 27, 2024

Description:

There is a mismatch in terminology and display requirements between the aplus and mB projects, it was brought up here #1669 (comment)

aplus: Uses "vote" terminology without displaying text, relying on hidden messages for screen readers.
mB: Uses "like" terminology and requires visible "Likes/Dislikes" text.

Proposed Action

Unify the approach by displaying text on both platforms or use same wording for the screen reader option
Use CSS to hide or show the respectives text as needed per platform, reducing complexity and avoiding custom logic.

mB aplus
rating-mb ratings-aplus

Participants:

@goapunk
@hom3mad3
@TeaJayyy
@CarolingerSeilchenspringer

@hom3mad3 hom3mad3 added Dev: Refactor issues to be fixed with code refactor Status: Decision Needed Issues that are blocked because decision is needed Dev: Frontend labels Aug 27, 2024
@CarolingerSeilchenspringer

@hom3mad3 @goapunk @TeaJayyy sounds plausible. I would argue for "like/dislike" as in mB we have voting as another feature. The question to me is if we want to stick to the current design in a+ or also change to the like/dislike from mB. I add @MarleyMi with the questions if we have some insights from the a+ usertesting regarding the rating.

@hom3mad3
Copy link
Contributor Author

@hom3mad3 @goapunk @TeaJayyy sounds plausible. I would argue for "like/dislike" as in mB we have voting as another feature. The question to me is if we want to stick to the current design in a+ or also change to the like/dislike from mB. I add @MarleyMi with the questions if we have some insights from the a+ usertesting regarding the rating.

if we decide to have a more complex element with different wording, then would make sense to refactor the ratings component to account for different use cases

@CarolingerSeilchenspringer

@hom3mad3 @TeaJayyy I think we should have the same wording for our core features throughout our platforms. Makes not only development easier but also PM/PR work.

@t-j-q
Copy link

t-j-q commented Aug 28, 2024

@hom3mad3 @CarolingerSeilchenspringer I also prefer the like/dislike option although, generally speaking, I visioned a "support" functionality, without dislikes. For the moment having like/dislike is a good start and using the thumbs is more clear than arrows. Design-wise I agree that a+ and mb should be closer together regarding their core features. The main problem is that I'm not sure when we can tackle this due to budget constraints for a+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: Frontend Dev: Refactor issues to be fixed with code refactor Status: Decision Needed Issues that are blocked because decision is needed
Projects
None yet
Development

No branches or pull requests

3 participants