Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HWP angle #336

Closed
paganol opened this issue Oct 23, 2024 · 0 comments · Fixed by #340
Closed

HWP angle #336

paganol opened this issue Oct 23, 2024 · 0 comments · Fixed by #340

Comments

@paganol
Copy link
Member

paganol commented Oct 23, 2024

The array stored in observation.hwp_angle (or returned by observation.get_pointings()) contains twice the hwp angle, this has a historical reason and it is related to the way the pointing was handled before. Should we reconsider this behavior, and return just the hwp angle? What do you think, @ziotom78 @sgiardie @nraffuzz @ggalloni? Btw, this is also relevant for the beam convolution module #170.
Also the documentation is not very clear on this aspect, and we should clarify this.

@njit
def _get_ideal_hwp_angle(
    output_buffer, start_time_s, delta_time_s, start_angle_rad, ang_speed_radpsec
):
    for sample_idx in range(output_buffer.size):
        angle = (
            start_angle_rad
            + (start_time_s + delta_time_s * sample_idx) * 2 * ang_speed_radpsec
        ) % (2 * np.pi)

        output_buffer[sample_idx] = angle
@paganol paganol linked a pull request Oct 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant