Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦺[Tech Debt]: Remove device authPrompt & make users access the 6 digit PIN / LoginActivity.java only #242

Open
4 tasks
kcw-grunt opened this issue Oct 6, 2024 · 4 comments
Assignees
Labels
🦺 tech debt Actions that help maintain the repo and application
Milestone

Comments

@kcw-grunt
Copy link
Contributor

kcw-grunt commented Oct 6, 2024

Describe the work to be done

The current configuration is the User cannot progress when starting without setting a device PIN or fingerprint.
This has been a complaint for years because the user must remember 2 sets of PINs....and it slows the user flow.

It is also the source of the most number of crashes. This should be fixed.

Even though this interface will be retired soon, users are increasing so if we can remove this will be appreciated

Note: This is not to remove the Blue 6 digit PIN lock screen (LoginActivity).

Remove this view
Screenshot 2024-10-06 at 8 36 45 PM

Steps to complete

  • Look at the 6 calls to public void authPrompt in AuthManager.java
  • Hacky Solution: Just remove the test and pass completion in the method authPrompt
  • Better Solution: Remove any calls to authPrompt but make sure the LoginActivity is shown when opening the app and locks when the user locks in Settings
  • Test
@kcw-grunt kcw-grunt added the 🦺 tech debt Actions that help maintain the repo and application label Oct 6, 2024
@kcw-grunt kcw-grunt assigned kcw-grunt and josikie and unassigned josikie and kcw-grunt Oct 6, 2024
@kcw-grunt kcw-grunt pinned this issue Oct 6, 2024
@kcw-grunt kcw-grunt changed the title 🦺[Tech Debt]: Remove device authPrompt and make users to access the 6 digit PIN only 🦺[Tech Debt]: Remove device authPrompt and make users to access the 6 digit PIN / LoginActivity.java only Oct 6, 2024
@kcw-grunt kcw-grunt changed the title 🦺[Tech Debt]: Remove device authPrompt and make users to access the 6 digit PIN / LoginActivity.java only 🦺[Tech Debt]: Remove device authPrompt & make users access the 6 digit PIN / LoginActivity.java only Oct 6, 2024
@kcw-grunt kcw-grunt changed the title 🦺[Tech Debt]: Remove device authPrompt & make users access the 6 digit PIN / LoginActivity.java only 🦺[Tech Debt]: Remove device authPrompt & make users access the 6 digit PIN / LoginActivity.java **only** Oct 6, 2024
@kcw-grunt kcw-grunt changed the title 🦺[Tech Debt]: Remove device authPrompt & make users access the 6 digit PIN / LoginActivity.java **only** 🦺[Tech Debt]: Remove device authPrompt & make users access the 6 digit PIN / LoginActivity.java only Oct 6, 2024
@kcw-grunt
Copy link
Contributor Author

@kcw-grunt
Copy link
Contributor Author

Github Issue

@kcw-grunt kcw-grunt unpinned this issue Oct 11, 2024
@kcw-grunt
Copy link
Contributor Author

Branch: bugfix/auth-prompt-error

@kcw-grunt kcw-grunt added this to the v2.12.X milestone Nov 5, 2024
@kcw-grunt
Copy link
Contributor Author

cc @andhikayuana

@kcw-grunt kcw-grunt self-assigned this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦺 tech debt Actions that help maintain the repo and application
Projects
None yet
Development

No branches or pull requests

2 participants