Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenDAL as a kind of cache adapter #982

Open
Xuanwo opened this issue Nov 11, 2024 · 4 comments
Open

Add OpenDAL as a kind of cache adapter #982

Xuanwo opened this issue Nov 11, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Xuanwo
Copy link
Contributor

Xuanwo commented Nov 11, 2024

Feature Request

Integrate OpenDAL as a type of cache adapter that can be used with redis/memcached/mini-moka more easier.

Describe the solution you'd like

Implement OpendalCacheAdapter like we do for #948

Describe alternatives you've considered

Not yet.


I'm happy to submit a PR for this.

@kaplanelad
Copy link
Contributor

Hi @Xuanwo,
Just checking in—does this issue still seem relevant from your perspective? Should we move forward with it?

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jan 6, 2025

Hi @Xuanwo, Just checking in—does this issue still seem relevant from your perspective? Should we move forward with it?

Hi @kaplanelad, in #978, we introduced storage support using opendal. This issue proposes utilizing opendal as a new cache adapter. Do you think it would be worthwhile to integrate more cache storage services through opendal, such as moka, mini_moka, memcached, and others?

@DenuxPlays
Copy link
Contributor

I agree with Xuanwo.
This would add a lot of cache implementations without too much work.
Things like redis and memcache are the big ones imo.

@kaplanelad
Copy link
Contributor

@Xuanwo, I believe replacing the in-memory implementation would be a good step forward, and we should continue with just the Redis implementation rather than maintaining the rest.

However, once we are running with the OpenDAL engine, it will make things easier for users. They’ll only need to implement our cache trait with other OpenDAL drivers to extend functionality. If some other driver is not implemented in loco (like the list that you mentioned) a framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants