From 4010cf0f3f6d34dd5b88f2c78b3476e69b033388 Mon Sep 17 00:00:00 2001 From: Arun Kannawadi Date: Mon, 27 Nov 2023 10:43:00 -0800 Subject: [PATCH] fixup: post reivew fixes --- python/lsst/drp/tasks/assemble_cell_coadd.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/python/lsst/drp/tasks/assemble_cell_coadd.py b/python/lsst/drp/tasks/assemble_cell_coadd.py index e3309451..1d670849 100644 --- a/python/lsst/drp/tasks/assemble_cell_coadd.py +++ b/python/lsst/drp/tasks/assemble_cell_coadd.py @@ -31,6 +31,7 @@ import numpy as np from lsst.cell_coadds import ( CellIdentifiers, + CoaddUnits, CommonComponents, GridContainer, MultipleCellCoadd, @@ -96,7 +97,7 @@ class AssembleCellCoaddConfig(PipelineTaskConfig, pipelineConnections=AssembleCe calc_error_from_input_variance = Field[bool]( doc="Calculate coadd variance from input variance by stacking " "statistic. Passed to AccumulatorMeanStack.", - default=True, + default=False, ) max_maskfrac = RangeField[float]( doc="Maximum fraction of masked pixels in a cell. This is currently " @@ -183,7 +184,7 @@ def runQuantum(self, butlerQC, inputRefs, outputRefs): ) self.common = CommonComponents( - units=None, # until the ScaleZeroPointTask can scale it to nJy. + units=CoaddUnits.legacy, # until the ScaleZeroPointTask can scale it to nJy. wcs=inputData["skyInfo"].patchInfo.wcs, band=outputDataId.get("band", None), identifiers=PatchIdentifiers.from_data_id(outputDataId), @@ -259,7 +260,7 @@ def _construct_grid_container(self, skyInfo, statsCtrl): stacker = AccumulatorMeanStack( # The shape is for the numpy arrays, hence transposed. shape=(cellInfo.outer_bbox.height, cellInfo.outer_bbox.width), - bit_mask_value=statsCtrl.getAndMask(), + bit_mask_value=afwImage.Mask.getPlaneBitMask(self.config.bad_mask_planes), calc_error_from_input_variance=self.config.calc_error_from_input_variance, compute_n_image=False, )