Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More descriptive variable names #5

Open
szepeviktor opened this issue Jun 24, 2020 · 2 comments
Open

More descriptive variable names #5

szepeviktor opened this issue Jun 24, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@szepeviktor
Copy link
Contributor 

            "license_var": "PRODUCT_LICENSE",
            "url_var": "PRODUCT_ACTIVATION_URL"

Could we rename these two?
@szepeviktor
Copy link
Contributor Author

@ajitbohra adding _var would show that it is not a value but a variable name.
Please.

@ajitbohra ajitbohra added the enhancement New feature or request label Sep 21, 2020
@ajitbohra
Copy link
Member

sounds good we can rename for more clarity and also support the existing one for backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szepeviktor @ajitbohra