Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store access credentials are necessary #8

Open
szepeviktor opened this issue Sep 19, 2020 · 6 comments
Open

Store access credentials are necessary #8

szepeviktor opened this issue Sep 19, 2020 · 6 comments

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Sep 19, 2020

Add the store access credentials.

@ajitbohra How does a plugin self-update itself with a single license key?

Why does composer-edd-plugin need store access credentials too?
Please advise.

@ajitbohra
Copy link
Member

  • Plugin will not be able to self-update as we need to manually bump the version numbers
  • auth credentials are required to download the final release zip without auth details download will fail

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Sep 21, 2020

I do not understand.

AFAIK A plugin using EDD to update itself has only a license key. How does WP update mechanism operate with a single license key?

@ajitbohra
Copy link
Member

You are right for a plugin, update happens with just a license key.

We have dev, staging & production env and composer install was failing to get through, and adding auth details helped.

May be with further investigation we might be able to get the root cause of this and eliminate the need for auth details.

@szepeviktor
Copy link
Contributor Author

These are the 3 steps to download a ZIP from the seller's website:

ffraenz/private-composer-installer#22 (comment)

@ajitbohra
Copy link
Member

step 3 is where currently we need the auth credentials for the store

@szepeviktor
Copy link
Contributor Author

I see.
Thank you.

  • change user-agent?
  • rate limited?
  • any other behavior difference from WP core's HTTP client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants