Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding to liquid to serialize #258

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

HassanAkbar
Copy link
Member

Added to_liquid method to Lutaml::Model::Serialize

closes #180

@HassanAkbar HassanAkbar requested a review from ronaldtse January 20, 2025 15:04

module Lutaml
module Model
module Liquidatable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HassanAkbar can we rename this as "liquefiable"? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done it.

# "John"
puts person_drop.age
# 22
----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an example on how to call Liquid rendering on a template and using these drop methods, that span multiple levels? Also add an example on "filtering an item" in a collection. I feel that it's an easy add with AI.

@ronaldtse
Copy link
Contributor

@HassanAkbar can we rebase this PR and merge it? We can deal with documentation later. Thanks!

@HassanAkbar HassanAkbar force-pushed the adding_to_liquid_to_serialize branch from b3b7ed1 to 47f2d4e Compare February 4, 2025 07:24
@HassanAkbar HassanAkbar merged commit 7dca54f into main Feb 4, 2025
51 of 81 checks passed
@HassanAkbar HassanAkbar deleted the adding_to_liquid_to_serialize branch February 4, 2025 07:50
@HassanAkbar HassanAkbar restored the adding_to_liquid_to_serialize branch February 4, 2025 07:51
@HassanAkbar HassanAkbar deleted the adding_to_liquid_to_serialize branch February 4, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to_liquid for Lutaml::Model::Serializable to allow conversion to Liquid::Drop objects
2 participants