-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge canary and master #72
Comments
Totally agree with the hardness of keeping both branches in sync. The only problem is that Flow type, databases, and much more should be optional, which should be done using Yeoman. If we merge canary and master, this will force all users to use Flow type, our chosen database, and etc. Here is my initial thought. |
Okay, then I'll seriously look into subgenerators :) |
I've created a new branch yeoman-experimental. Please look into it, if it makes sense. I can't PR it to yeoman-generator, because GH won't let me. |
Hey @Neitsch, thanks for creating the experimental branch. It's going in the right direction that we were discussing. I think the easiest way that we could do is to move all the files inside the Then, we could write a script to automatically generate the master branch from our |
Yeah, I guess I can do the whole thing from the generator branch instead. Will work on the PR soon then. |
Sounds like a great plan! :) I think after merging canary into yeoman-generator, we won't need to generate canary anymore, it'll be removed completely. We'll need to generate only the 'master' branch.
Looking forward to seeing your awesome PR ;)
|
@Neitsch, could you please update the current status of this issue? I'll be free this weekend, would like take some tasks of the issue. |
Hi @lvarayut , sorry I've been slacking off on work. Right now work is pretty busy. We'll first have to merge relay router. Then we we have a good working basis to get the generator going. |
I've merged the canary into master. We would stop maintaining the yeoman branch for now until we can find a good way to maintain it. In conclusion: two active branches: |
I think we should merge canary back into master. It's hard to keep both branches in sync.
Thoughts?
The text was updated successfully, but these errors were encountered: