Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation Success Url #78

Open
jclif opened this issue Aug 27, 2016 · 9 comments
Open

Confirmation Success Url #78

jclif opened this issue Aug 27, 2016 · 9 comments

Comments

@jclif
Copy link

jclif commented Aug 27, 2016

Howdy!

I'm experiencing some issues with the confirmation flow. When I try to sign in as a new user, I am redirected back to the signup page but my app is throwing an error that I don't recognize. Has anyone encountered this particular issue?

Should I be setting the confirm_success_url within settings when I call configure?

The error I'm seeing is:
TypeError: Cannot read property 'replace' of undefined

signup_error

@jclif
Copy link
Author

jclif commented Aug 28, 2016

I believe this might be related to #77.

@jclif
Copy link
Author

jclif commented Aug 28, 2016

@lynndylanhurley From what I can tell, the line:

value.replace(/[^+#$&/:<-\[\]-}]/g, encodeURIComponent)

fails when the variable called name is a string 'authHeaders' because value is undefined.

@betoharres
Copy link

it looks like the same problem as mine. Did you have this problem when trying to reset the password as well?

@vijaychouhan-rails
Copy link

Please set the config.action_mailer.default_url_options = { :host => 'https://localhost:3000' } in Rails application at development.rb

@jclif
Copy link
Author

jclif commented Sep 16, 2016

@vijaychouhan-rails I believe the rails server has the correct email url; it links me to my front-end application correctly.

@jclif
Copy link
Author

jclif commented Sep 24, 2016

@betoharres Yes, this happens on password change as well. What has been your solution to this? We would like to use this library for auth, but we are stuck because of these issues.

@betoharres
Copy link

@jclif Yeah, I did a PR 10 days ago fixing these problems, you can check it out my solution here, but it was not merged. I'm using this lib locally with my modifications.
But the thing is: if you clone this repo right now in the master branch and run it's tests, it will show all green even with all these errors. When I fixed, I broke 24 tests but I fixed the problem and everything else works the same.
If you know anything about the tests used in this lib, please help us out, it will be very welcome ❤️

@jclif
Copy link
Author

jclif commented Sep 27, 2016

@betoharres Interestingly, when I run these tests locally, they appear to pass without any problems.

@betoharres
Copy link

@jclif They do, that's the problem! haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants