Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: DeepL Glossary #3

Open
lyqht opened this issue Jul 2, 2023 · 1 comment
Open

Feature Request: DeepL Glossary #3

lyqht opened this issue Jul 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@lyqht
Copy link
Owner

lyqht commented Jul 2, 2023

Context

At the moment, if users run the github action multiple times, it may be possible that for some languages, the translated text may be slightly different than the previous translation results. If users want to keep them/ override them, they would have to make a separate commit.

Hence, it will be good if users can create their own custom dictionary of translation resutls based on the previous translation result that the github action has already provided for them before. In the DeepL API docs , this is known as glossaries.

Acceptance criteria

At the github action side, we need to add an action prop for glossary_name for users to input their own glossary, while adding logic to check for existing glossary translation results before overriding them. For now, this feature only needs to work for JSON files since it will be quite complicated to do so with HTML-like files.

@lyqht lyqht added the enhancement New feature or request label Jul 2, 2023
@ocaisa
Copy link

ocaisa commented Sep 19, 2023

Would it be possible to support people to provide the path to their own glossary in a csv format (i.e., as part of their repository) and use createGlossaryWithCsv()? Then one could:

  • Upload the glossary to get the necessary glossary ID
  • Use the glossary ID when making translations
  • Delete the glossary when the action finishes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants