Remove membership types from the client

[arkoebel]

I thought that PR#6 was supposed to remove member types from the client, but maybe I was mistaken.

Membership types are still somewhat hardcoded in the client (in NewMemberCard.jsx, Upgrade.jsx, MemberTypeList.jsx).

1 - It makes merging more difficult for Worldcons who used different MemberTypes
2 - It forces to recompile the client when a new membership type needs to be added/removed

MemberTypes (and indeed anything that can change over time) should come from the API and not be hardcoded in the client.

[eemeli]

#6 did help in getting rid of some of the client-side definitions, but there's certainly remnants as you've found. As is, the expectation is that you'll customise the client code directly, including these member type changes.

The current client-side architecture as a whole is far too clumsy and monolithic, and I'm working now on breaking it apart into configurable modules, here: https://github.com/maailma/kansa/tree/dev/client (note the merge back into the kansa repo, as per my comment on Gitter a bit over a week ago). As that progresses, the member types should also get sorted at some point.

FYI, I do not have current plans of backporting changes from dev to master.