Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to share data between sections #106

Open
code-bunny opened this issue Dec 29, 2024 · 2 comments
Open

Add a setting to share data between sections #106

code-bunny opened this issue Dec 29, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@code-bunny
Copy link

For my new site I've made a header and a header with a full screen height call to action/welcome. Currently I need add the nav links on both or have the main app handle the nav/header.

Is there some setting I am missing where site_scoped can work on both the main_header and the cta_header?

@did did added the enhancement New feature or request label Jan 5, 2025
@did
Copy link
Contributor

did commented Jan 5, 2025

site_scoped allows you to share the data of a component between different pages.
What you're asking for is to share data between 2 different components.
I think that'd be a great addition.

@code-bunny
Copy link
Author

Aye. I think it would be confusing for customers. So if I provide 3 different footers and 2 different headers... why would the user need to know they have to update all the menus. And then they'll need to know they have to go to different pages to update the different site scoped menus. Of course this should be optional. Or maybe we can have some menu builder that we can reference in the editor.

In my footer I'll always want to have the terms and privacy policy links. But maybe on a landing page I want a minimal footer with just those links while on the main site I have a full fat footer. Also common on shopping sites where there is a minimal header and footer for the checkout pages.

I think this may be better served with blocks we can share between components. Or menu builders that can be referenced in blocks. Building up your menu's in a dedicated menu UI that can then be referenced in different blocks would seem the most logical way to go. It also means in the site.yml the initial menus are defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants