Undefined method NoMethodError average

[railskipl]

I am getting following error while rating
(undefined method `average' for #Mongoid::Criteria:0xb335e5b8)

   def update_rate_average(stars)
      if average.nil?
        RatingCache.create! do |avg|
          avg.cacheable_id = self.id
          avg.cacheable_type = self.class.name
          avg.avg = stars
          avg.qty = 1
        end
      else
        a = average
        a.qty = rates.count
        a.avg = rates.average(:stars) #error is here.. average method 
        a.save!(validate: false)
      end
    end

I am not getting, where average method is defined?

[malagant]

You’ll find that average is a relation defined in the concern: https://github.com/malagant/mongoid-letsrate/blob/master/lib/mongoid/letsrate/model.rb#L78

An 24. Februar 2014 at 08:33:31, railskipl ([email protected]://[email protected]) schrieb:

I am getting following error while rating
(undefined method `average' for #Mongoid::Criteria:0xb335e5b8)

def update_rate_average(stars)
if average.nil?
RatingCache.create! do |avg|
avg.cacheable_id = self.id
avg.cacheable_type = self.class.name
avg.avg = stars
avg.qty = 1
end
else
a = average
a.qty = rates.count
a.avg = rates.average(:stars) #error is here.. average method
a.save!(validate: false)
end
end

I am not getting, where average method is defined?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1.

[railskipl]

But still, I am not able to understand why it giving error.. at rates.average(:stars)

[malagant]

I checked in the rails console and can't reproduce the error? Which mongoid gem version do you use? How do you create the rating? Pleas provide more details and I will be happy to support you.

[malagant]

sorry, found the bug. Please wait for a fix.

[railskipl]

thanks.. also I've encounter one issue :

 def can_rate?(user)
      user.ratings_given.where(rateable_id: id, rateable_type: self.class.name).size.zero?
 end

When I am inspecting user.ratings_given.where(rateable_id: id, rateable_type: self.class.name).size is returning me zero all the time, in which case can_rate? is always returning true even though user rated the model.

[malagant]

A fix for "average" is now in the repo and I released a new gem. I swear, that I will provide tests i the next release. ;)

[malagant]

For your second problem. The code works if you run it in the right context. E.g. I tried it in the rails console and found out, that the rateable_type could be Object in your example. If you use the right one, it returns correct values. Am I right?

[railskipl]

First time when I rate it rates properly, but then again I rate ,it is not displaying rating. For example when I am rating 5 stars by [email protected](say) first time it rates properly then again I try to rate with 2 stars(same email) it should raise an error "User already rate" but it is not raising and it is not displaying the previous rating i.e. 5 stars also. Also I've tried the other way... I mean to say first I rate a car with [email protected] and then when I try to rate the same car with [email protected] I am not able to rate it when I refresh rating is gone for [email protected].
Also, the second issue which I've mentioned earlier it is still showing me zero all the time.

[railskipl]

I've just now visited the rails console and found that when I rate first time say 2 stars avg. value in RatingCache is 2.0 but then again when I rate with another email with rating 5 stars, the avg. value is 0.0.

 RatingCache.all.to_a
 => [#<RatingCache _id: 530c35bccc79c22064000011, created_at: 2014-02-25 06:18:36 UTC, updated_at: 2014-02-25 06:18:36 UTC, avg: 1.0, qty: 1, cacheable_type: "Car", cacheable_field: nil, cacheable_id: "530c319ecc79c2012e000001">] 
1.9.3p448 :028 > RatingCache.all.to_a
 => [#<RatingCache _id: 530c35bccc79c22064000011, created_at: 2014-02-25 06:18:36 UTC, updated_at: 2014-02-25 06:19:05 UTC, avg: 0.0, qty: 2, cacheable_type: "Car", cacheable_field: nil, cacheable_id: "530c319ecc79c2012e000001">] 

[railskipl]

I've found that rater_id in user model is nil. When I try to update rater_id from console it is raising an error
user.rater_id = "12345"
NameError: uninitialized constant Rater
Is it a reason for the second issue which I've mentioned yesterday. user.ratings_given.where(rateable_id: id, rateable_type: self.class.name).size

[railskipl]

I've managed to find average as

    def update_rate_average(stars)
      if average.nil?
        RatingCache.create! do |avg|
          avg.cacheable_id = self.id
          avg.cacheable_type = self.class.name
          avg.avg = stars
          avg.qty = 1
        end
      else
        a = average
        str ||= []
        str << rates.map { |e| e.stars  }
        avg = str.flatten.inject(:+)/str.flatten.length #average
        a.qty = rates.count
        a.avg = avg
        a.save!(validate: false)
      end
    end

[malagant]

I am currently writing the needed specs. I have to confess, that I did a quick and dirty write without any testing. I will provide something later this evening. Thank you for your patience.