Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some closed windows are restored #12

Open
zoidy opened this issue Dec 19, 2018 · 4 comments
Open

Some closed windows are restored #12

zoidy opened this issue Dec 19, 2018 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@zoidy
Copy link

zoidy commented Dec 19, 2018

Using branch I0010-restoring-positions-doesnt-work as requested in #4

Saving and restoring windows (using the built-in timer to avoid having to click Get Windows, Save Config, Read Config) works well. Maybe too well. Certain windows that I've closed get "restored" after I re-dock. I can reproduce reliable with the Outlook Reminders window (other windows like pop-ups sometimes do it too.

Steps

  1. Start from a freshly rebooted computer, docked
  2. Open the Outlook (2016) App on a secondary monitor
  3. Open the Outlook reminder window and move to primary monitor (if not there already)
  4. Wait a few sec for WinRedock to save windows
  5. Close the reminder window
  6. Undock and redock
  7. Reminder window re-appears, even though I had closed it.
    wm.log
@manutalcual manutalcual self-assigned this Dec 20, 2018
@manutalcual manutalcual added the bug Something isn't working label Dec 20, 2018
@manutalcual
Copy link
Owner

I suspect those re-appearing windows aren't really closed, they are just hidden. That's why they reappear.
I've done some modifications to try to not take in account those.
Could you try?

Thanks.

@zoidy
Copy link
Author

zoidy commented Dec 20, 2018

Thanks for the quick update, I think the issue is partially fixed.

If instead of closing the window before undocking, you undock first and then close it, the window will re-appear when you re-dock.

manutalcual added a commit that referenced this issue Dec 21, 2018
@manutalcual
Copy link
Owner

I've added code to remove another configurations closed windows from the current one.
If you have time could you test it?

Thanks a lot.

@zoidy
Copy link
Author

zoidy commented Dec 21, 2018

It seems like it didn't work :( The closed window still re-appears (tested with the Outlook reminders window)
wm.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants