Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] update canvas dependency #1433

Closed
farfromrefug opened this issue Jan 10, 2025 · 2 comments
Closed

[FR] update canvas dependency #1433

farfromrefug opened this issue Jan 10, 2025 · 2 comments

Comments

@farfromrefug
Copy link

Would be awesome if you could update the canvas dependency. Right now version 2.x wont build with latest node versions. version 3.x now uses NAPI which means it will compile.
Right now we have to use node 20.18.1 or we cant compile tileserver-gl

acalcutt added a commit to WifiDB/tileserver-gl that referenced this issue Jan 10, 2025
acalcutt added a commit that referenced this issue Jan 11, 2025
* first attempt to upgrade express to v5

Co-Authored-By: Andrew Calcutt <[email protected]>

* try to fix #1411

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup server.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup serve_font.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup sever_rendered.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup server_data.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup serve_style

Co-Authored-By: Andrew Calcutt <[email protected]>

* Update serve_style.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* Move UV_THREADPOOL_SIZE  to main thred

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup utils.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* Use common app.get for images and static images

Co-Authored-By: Andrew Calcutt <[email protected]>

* add allowedTileSizes and option

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup error responses

Co-Authored-By: Andrew Calcutt <[email protected]>

* fix /style/id.json with next('route')

Co-Authored-By: Andrew Calcutt <[email protected]>

* improve sprite path

Co-Authored-By: Andrew Calcutt <[email protected]>

* add parseFloadts around zxy

Co-Authored-By: Andrew Calcutt <[email protected]>

* simplify server_data

Co-Authored-By: Andrew Calcutt <[email protected]>

* move tile fetch and add fix verbose logging

Co-Authored-By: Andrew Calcutt <[email protected]>

* add Handling request to verbose logging

Co-Authored-By: Andrew Calcutt <[email protected]>

* first attempt to upgrade express to v5

Co-Authored-By: Andrew Calcutt <[email protected]>

* try to fix #1411

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup server.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup serve_font.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup sever_rendered.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup server_data.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup serve_style

Co-Authored-By: Andrew Calcutt <[email protected]>

* Update serve_style.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* Move UV_THREADPOOL_SIZE  to main thred

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup utils.js

Co-Authored-By: Andrew Calcutt <[email protected]>

* Use common app.get for images and static images

Co-Authored-By: Andrew Calcutt <[email protected]>

* add allowedTileSizes and option

Co-Authored-By: Andrew Calcutt <[email protected]>

* cleanup error responses

Co-Authored-By: Andrew Calcutt <[email protected]>

* fix /style/id.json with next('route')

Co-Authored-By: Andrew Calcutt <[email protected]>

* improve sprite path

Co-Authored-By: Andrew Calcutt <[email protected]>

* add parseFloadts around zxy

Co-Authored-By: Andrew Calcutt <[email protected]>

* simplify server_data

Co-Authored-By: Andrew Calcutt <[email protected]>

* move tile fetch and add fix verbose logging

Co-Authored-By: Andrew Calcutt <[email protected]>

* add Handling request to verbose logging

Co-Authored-By: Andrew Calcutt <[email protected]>

* merge elevation changes

* lint format

* add verbose logging, improve headers

* try to fix codeql

Information exposure through a stack trace

* test

* all tests passing

* cleanup unneeded changes

* cleanup

* try to fix codeql error

* font fixes

* fix tile size issue

* try to improve scale + codeql

* codeql for sprite logging

* codeql serve fonts

* codeql fixes

* fix failing test with multiple fonts

* Update serve_font.js

* codeql

* codeql

* codeql

* Update utils.js

* codeql

* codeql

* codeql

* codeql

* codeql sanitize

* Update serve_font.js

* Update serve_font.js

* remove useless assignment

* move isGzipped

* add if-modified-since and cache-control

* use consistent cache control

* reformat

* codeql

* codeql

* codeql

* codeql

* codeql

* codeql

* codeql

* Update serve_font.js

* Update serve_font.js

* Update serve_font.js

* Update serve_style.js

* Update serve_style.js

* Update serve_style.js

* Revert "Update serve_style.js"

This reverts commit e0574b1.

* Revert "Update serve_style.js"

This reverts commit b1e1d72.

* Revert "Update serve_style.js"

This reverts commit 0f3629c.

* Add readFile function

* use readFile, add path.normalize

* Update serve_rendered.js

* simplify input checking

* Update utils.js

* codeql

* Revert "codeql"

This reverts commit e18874f.

* Revert "Update utils.js"

This reverts commit 5de617d.

* Revert "simplify input checking"

This reverts commit 62a3212.

* move allowed functions to utils.js

* use xy[0],xy[1],

* uprade canvas per #1433

* make font regex less restrictive

* fix regex error

* Add version and changelog

* Update CHANGELOG.md

* Update CHANGELOG.md
@acalcutt
Copy link
Collaborator

acalcutt commented Jan 11, 2025

Should be Fixed by #1429 , which is included as of 5.1.0 (but I recommend 5.1.1)

@farfromrefug
Copy link
Author

@acalcutt awesome thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants