Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments to store_diagnostics_ciso_interior need a derived type #18

Open
mnlevy1981 opened this issue Mar 21, 2016 · 4 comments
Open

Comments

@mnlevy1981
Copy link
Collaborator

In marbl_ciso_mod::marbl_ciso_set_interior_forcing the call to marbl_store_diagnostics_ciso_interior is preceded by the FIXME comment

the following arguments need to be grouped into a derived type
@mnlevy1981
Copy link
Collaborator Author

Similar comment applies to call to marbl_store_diagnostics_ciso_surface_forcing

@mvertens
Copy link
Collaborator

I cannot spend any more time on MARBL right now. We can leave this as a fix
me - or assign it to either you or Jon.

On Mon, Mar 21, 2016 at 1:16 PM, Michael Levy [email protected]
wrote:

Similar comment applies to call to
marbl_store_diagnostics_ciso_surface_forcing


You are receiving this because you were assigned.
Reply to this email directly or view it on GitHub
#18 (comment)

@mnlevy1981
Copy link
Collaborator Author

I don't think this is an urgent fix, I'm just trying to turn all the FIXMEs in the code into issue tickets so we don't lose track of them (I'm also including the issue number in the comments). I'll leave the assignee blank for now.

@mnlevy1981 mnlevy1981 added this to the Post-MARBL1.0.0 milestone Jan 24, 2017
@mnlevy1981
Copy link
Collaborator Author

We may develop a more general solution (keeping #53 in mind); a possible solution may also involve returning CISO values to marbl_mod and letting marbl_diagnostics_set_interior_forcing handle calling store_diagnostics_ciso

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants