Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all unused variables #276

Closed
mnlevy1981 opened this issue May 30, 2018 · 1 comment
Closed

Remove all unused variables #276

mnlevy1981 opened this issue May 30, 2018 · 1 comment
Assignees
Milestone

Comments

@mnlevy1981
Copy link
Collaborator

From #87 -- "NAG provides warnings about variables that are declared but not used, which will be very useful once the code is stable. Also, if we can reach a point where the code compiles without warnings it would be nice to turn on a compile flag to elevate warnings to errors in the test system to ensure the code stays that way."

@mnlevy1981 mnlevy1981 added this to the MARBL1.0.0 milestone May 30, 2018
@mnlevy1981 mnlevy1981 self-assigned this May 30, 2018
@klindsay28
Copy link
Collaborator

Adding -Wall to CFLAGS for gnu will catch this, and can be caught by travis-ci.
Once we eliminate all warnings from gnu -Wall, we can add -Werror and travis-ci will keep us honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants