Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull particulate share out of compute_particulate_terms? #28

Open
mnlevy1981 opened this issue Mar 21, 2016 · 3 comments
Open

Pull particulate share out of compute_particulate_terms? #28

mnlevy1981 opened this issue Mar 21, 2016 · 3 comments
Labels
MARBL enhancement
Milestone
Post-MARBL1.0.0

Comments

@mnlevy1981
Copy link
Collaborator

FIXME comment in marbl_mod::marbl_set_interior_forcing:

need to pull particulate share out
of compute_particulate_terms!
@mnlevy1981
Copy link
Collaborator Author

To clarify: right now we pass compute_particulate_terms both marbl_particulate_share AND arguments that have been aliased to members of marbl_particulate_share. I think the FIXME is suggesting we want to update the routine to only accept the latter.

@mnlevy1981
Copy link
Collaborator Author

mnlevy1981 commented Jun 2, 2016 •
edited
Loading

(Also, there is a similar issue in marbl_ciso_mod)

@mnlevy1981 mnlevy1981 added this to the Post-MARBL1.0.0 milestone Jan 24, 2017
@mnlevy1981
Copy link
Collaborator Author

See #313 (if we change the POC_remin that is passed to ciso to include sediment flux, we can export to share after returning from compute_particulate_terms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
MARBL enhancement
Projects
None yet
Milestone
Post-MARBL1.0.0
Development

No branches or pull requests
1 participant
@mnlevy1981