Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bury coefficients should be in their own datatype, not particulate_share #325

Open
mnlevy1981 opened this issue Oct 17, 2018 · 1 comment
Milestone

Comments

@mnlevy1981
Copy link
Collaborator

The *_share_type variables are to store data that needs to be passed from the base tracer module to the carbon isotopes but isn't already in memory (e.g. instead of passing zooplankton_local, we sum some elements over the zooplankton_cnt dimension). By this definition, the bury coefficients should not be in particulate_share.

Where they should be is a harder question. Perhaps in their own bury_coeff_type? Or maybe they fit into an existing type.

@mnlevy1981 mnlevy1981 added this to the MARBL1.0.0 milestone Oct 23, 2018
@mnlevy1981
Copy link
Collaborator Author

This may be easily addressed alongside either #53 or #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant