Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create template for pull requests and commits #45

Open
mnlevy1981 opened this issue Apr 4, 2016 · 1 comment
Open

Create template for pull requests and commits #45

mnlevy1981 opened this issue Apr 4, 2016 · 1 comment

Comments

@mnlevy1981
Copy link
Collaborator

A template for pull requests would let us provide developers with a check-list to make sure the code has been properly tested. Things to include in check list:

  • Is code bit-for-bit with previous tag?
  • Does pull request address an issue ticket? If so, which one?
  • Has the MARBL API changed?
  • What testing has been done?
  • Make sure code meets with standards outlined in design document / wiki
@mnlevy1981
Copy link
Collaborator Author

@klindsay28 pointed out that CTSM is having a good discussion about how github lets you provide multiple templates for different types of issues:

ESCOMP/CTSM#422

@billsacks went as far as to set up a toy repository with multiple templates... the templates are in

https://github.com/billsacks/ctsm-github-multiple-issue-templates/tree/master/.github/ISSUE_TEMPLATE

and when you click on "New Issue" you get taken to

https://github.com/billsacks/ctsm-github-multiple-issue-templates/issues/new/choose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant