Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are all the indexing types thread safe? #60

Open
mnlevy1981 opened this issue May 9, 2016 · 1 comment
Open

Are all the indexing types thread safe? #60

mnlevy1981 opened this issue May 9, 2016 · 1 comment

Comments

@mnlevy1981
Copy link
Collaborator

I noticed that the surface forcing output indices (sfo_ind) is a module variable in marbl_interface_types.F90, which probably isn't thread safe. I think we want all the various indices (surface forcing, surface forcing output, diagnostics, tracer, etc) stored in the marbl_interface_class so that there are copies for each MARBL instance.

@mnlevy1981
Copy link
Collaborator Author

Per #59 there are nine indexing types. Seven are already part of the interface:

  1. marbl_tracer_index_type
  2. marbl_living_tracer_index_type
  3. marbl_surface_forcing_indexing_type
  4. marbl_surface_saved_state_indexing_type
  5. marbl_interior_forcing_indexing_type
  6. marbl_interior_saved_state_indexing_type
  7. marbl_surface_forcing_output_indexing_type

But two are module variables in marbl_diagnostics_mod.F90:

  1. marbl_surface_forcing_diagnostics_indexing_type
  2. marbl_interior_diagnostics_indexing_type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant