Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass multiple columns to marbl%set_interior_forcing #81

Open
mnlevy1981 opened this issue Jun 27, 2016 · 2 comments
Open

Pass multiple columns to marbl%set_interior_forcing #81

mnlevy1981 opened this issue Jun 27, 2016 · 2 comments

Comments

@mnlevy1981
Copy link
Collaborator

Right now we can pass multiple columns to marbl%set_surface_forcing(), but marbl%set_interior_forcing has to be called one column at a time. It would likely be a huge performance gain if we could pass in multiple columns.

This would supercede #66, but that ticket raises a good point about how this assumption that num_elements_interior_forcing is assumed to be 1 at some points in the code.

@mnlevy1981 mnlevy1981 added this to the Feature-complete API milestone Jun 27, 2016
@mnlevy1981 mnlevy1981 self-assigned this Jun 27, 2016
@mnlevy1981
Copy link
Collaborator Author

mnlevy1981 commented Aug 15, 2016

No clear consensus on whether this would actually be a performance gain... so this is being put on the back-burner to be revisited later.

@mnlevy1981
Copy link
Collaborator Author

A lot of the MARBL code has a placeholder dimension for the column id -- currently this is the first dimension in the array, but is that where we want it? As written, we might be getting un-necessary memory copies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant