Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plotting #3

Open
marcosci opened this issue Dec 12, 2020 · 10 comments
Open

Improve plotting #3

marcosci opened this issue Dec 12, 2020 · 10 comments
Assignees

Comments

@marcosci
Copy link
Owner

Cedric, some more ggplot2 magic please.
And every function should have an optional start/end feature, like the "dot" option. I like that a lot!

@marcosci
Copy link
Owner Author

Go for it!

@z3tt
Copy link
Collaborator

z3tt commented Jan 11, 2021

Alles klar - letztes Mal hieß es noch das Package wird fallen gelassen, da steck ich doch keine Zeit rein dann :D

@marcosci
Copy link
Owner Author

marcosci commented Jan 12, 2021

There is now a plotting function for key tracking ... any suggestions? I dislike the legend, but don't have a better idea at the moment.

image

@z3tt
Copy link
Collaborator

z3tt commented Jan 12, 2021

Noice! Don't like the red boxes around the legend keys but that can be fixed.

@marcosci
Copy link
Owner Author

And the legend somehow needs to be continuous, not discrete ... 🤷

@z3tt
Copy link
Collaborator

z3tt commented Jan 12, 2021

Yes, usually by default. If not, guide_colorbar() didn't help?

@marcosci
Copy link
Owner Author

Oh, that did help. I used guide_legend ... anyway, if any of you wants to improve something, go for it!

@marcosci
Copy link
Owner Author

image

Current state

@z3tt
Copy link
Collaborator

z3tt commented Jan 12, 2021

guide_legend() draws a categorical legend, that#s what Hadley considers a "true legend" it seems. I'm busy this week but will come back to it. But looks nice already, maybe I'd use a bit more colorful palette but that's it :)

@z3tt
Copy link
Collaborator

z3tt commented Jun 8, 2021

Hi @marcosci, is this still something I should have a look at? Or are you happy with the latest version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants