Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak in remove_diagonal() #263

Closed
florian-huber opened this issue Jan 9, 2025 · 1 comment · Fixed by #264
Closed

Memory leak in remove_diagonal() #263

florian-huber opened this issue Jan 9, 2025 · 1 comment · Fixed by #264

Comments

@florian-huber
Copy link
Contributor

In some downstream tasks I realized that remove_diagonal() can cause memory leakage.
@florian-huber florian-huber mentioned this issue Jan 9, 2025
Merged
@niekdejonge
Copy link
Collaborator

Ah great, you found the memory leak! Do you think this was also the issue causing the memory leak when running the hyperparameter optimization?

@florian-huber florian-huber mentioned this issue Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alternative remove_diagonal implementation matchms/ms2deepscore
2 participants
@florian-huber @niekdejonge