Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore bluetooth support #37

Open
oz123 opened this issue Nov 17, 2015 · 6 comments
Open

restore bluetooth support #37

oz123 opened this issue Nov 17, 2015 · 6 comments

Comments

@oz123
Copy link

oz123 commented Nov 17, 2015

Could this be replaced with a dependency on blueman ?

oz123 added a commit to oz123/mate-de-gentoo that referenced this issue Nov 17, 2015
@raveit65
Copy link
Member

Well, we only change the default configure flag with e5f0552
A grep on source code shows that m-u-s depends on gsettings keys and one include from mate-bluetooth

src/user_share.c:39:#include <bluetooth-client.h>
src/user_share.c:74:#define OBEX_ENABLED (bluetoothd_enabled && has_console)
src/user_share.c:76:#define GSETTINGS_KEY_FILE_SHARING_BLUETOOTH_ENABLED "bluetooth-enabled"
src/user_share.c:77:#define GSETTINGS_KEY_FILE_SHARING_BLUETOOTH_ALLOW_WRITE "bluetooth-allow-write"
src/user_share.c:78:#define GSETTINGS_KEY_FILE_SHARING_BLUETOOTH_REQUIRE_PAIRING "bluetooth-require-pairing"
src/user_share.c:79:#define GSETTINGS_KEY_FILE_SHARING_BLUETOOTH_OBEXPUSH_ENABLED "bluetooth-obexpush-enabled"
src/user_share.c:80:#define GSETTINGS_KEY_FILE_SHARING_BLUETOOTH_OBEXPUSH_ACCEPT_FILES "bluetooth-accept-files"
src/user_share.c:81:#define GSETTINGS_KEY_FILE_SHARING_BLUETOOTH_OBEXPUSH_NOTIFY "bluetooth-notify"

Does blueman support this?

@monsta
Copy link
Contributor

monsta commented Nov 21, 2015

It's not a real dependency, just a build option in configure.ac.

@oz123
Copy link
Author

oz123 commented Nov 21, 2015

@monsta, I would reformulate the issue again:

m-s-u has an optional build dependency, which when enabled cannot be used.

You don't want to have an option which is recommending the usage of a software which is deprecated. The easier solution would be to completely remove it.
The better solution would be to make it work with blueman.

@monsta
Copy link
Contributor

monsta commented Nov 21, 2015

Yes, I agree. Need to do some research first about how to make it work with blueman...

@NP-Hardass
Copy link

obex-data-server is bluez4. GNOME migrated to obexd. obexd was absorbed into bluez5, so it works natively. I'd recommend that this route be undertaken. https://padovan.org/blog/2013/06/gnome-3-get-to-knows-bluez-5/ for reference.

@monsta
Copy link
Contributor

monsta commented Feb 21, 2016

As usual - pull requests are welcome 😄

@monsta monsta changed the title mate-user-share has a dependency on mate-blue-tooth which is removed restore bluetooth support Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants