-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible version of @date-io/core in dependencies & peerDependencies #47 #169
Comments
Thank you. This is especially odd because there was another issue for this which I resolved last night. It would seem v2.x has made it back. I will take a look here in a min (if you want to shoot over a PR real quick I can merge it as well) Thank you! |
Shouldn't downgrading the pickers library to a version that uses a date-io/core version that is compatible? Thoughts? |
Do you mean we shouldn't downgrade date-io/core? Otherwise I think I don't get it. |
Sorry that's my fault. We just need to downgrade date-io/core, right? I recently downgraded date-io/date-fns and I confused the two. |
I guess that's the easiest solution right now, just keep in mind that this issue is going to come up again with MUI 5 I can deal with this within a few hours and crate a PR if you want |
No doubt. That should be in the next major version (worrying about MUI5). v2.3.33 has been published with @date-io/core at v1.3.13. Please let me know if this is still an issue for you. |
Describe the bug
@material-table/core
requires@date-io/core@^2.10.6
, however@material-table/core
also has@material-ui/[email protected]
dependency with has@date-io/core@^1.3.6
as peer.To Reproduce
If you install
@material-table/[email protected]
and@date-io/core@^2.10.6
you'll see the following warningIf you install
@material-table/[email protected]
and@date-io/core@^1.3.6
you'll see the following warningExpected behavior
No warnings
Possible solutions
Since
@material-ui/pickers
is no longer supported, I guess we can:@date-io/core
The text was updated successfully, but these errors were encountered: