Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain Cycle cause by strong reference to delegate #74

Open
raphaeloliveira opened this issue Dec 18, 2015 · 2 comments
Open

Retain Cycle cause by strong reference to delegate #74

raphaeloliveira opened this issue Dec 18, 2015 · 2 comments

Comments

@raphaeloliveira
Copy link

Hey Matt, maybe I'm wrong but I think you should not have a strong reference to your delegate with the risk of causing a retain cycle.

https://github.com/mattconnolly/ZipArchive/blob/master/ZipArchive.h#L89

@mattconnolly
Copy link
Owner

I think you’re right. I haven’t looked at this project for a while now. Feel free to send a pull request.

-Matt

On 17 Dec 2015, at 7:26 PM, Raphael Oliveira [email protected] wrote:

Hey Matt, maybe I'm wrong but I think you should not have a strong reference to your delegate with the risk of causing a retain cycle

https://githubcom/mattconnolly/ZipArchive/blob/master/ZipArchiveh#L89


Reply to this email directly or view it on GitHub #74.

@hemang-azilen
Copy link

I'm getting following error (#66) when installing ZipArchive manually. Can you suggest me how to integrate it properly? I couldn't find any steps to do so. @mattconnolly @raphaeloliveira

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants