You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If there is no base token in explorer DB it gets it from config. Token gets added to the DB after token contract deployment event. For base token name and symbol are hardcoded to ETH on a contract level so when contract deployment event is indexed the token gets created in the DB with incorrect ETH name and symbol.
🔄 Reproduction Steps
set up custom base token chain;
update 800A contract to trigger deployment event;
notice base token name and symbol are changed to ETH;
🤔 Expected Behavior
Base token name and symbol should either be taken from config or from L1.
😯 Current Behavior
Base token name and symbol are set to ETH after 800A contract deployment event.
Suggested solution:
Always use name and symbol from config when saving base token to the DB. This way it still gets saved to the DB + name & symbol remain correct.
The text was updated successfully, but these errors were encountered:
We could not reproduce this issue. If base token is declared in api config it shows correct name when you use it, only problem that we found is when sending ETH on non ETH chain that token is displayed as unknown. Maybe we can include that inside of this ticket
🐛 Bug Report
📝 Description
If there is no base token in explorer DB it gets it from config. Token gets added to the DB after token contract deployment event. For base token name and symbol are hardcoded to ETH on a contract level so when contract deployment event is indexed the token gets created in the DB with incorrect ETH name and symbol.
🔄 Reproduction Steps
🤔 Expected Behavior
Base token name and symbol should either be taken from config or from L1.
😯 Current Behavior
Base token name and symbol are set to ETH after 800A contract deployment event.
Suggested solution:
Always use name and symbol from config when saving base token to the DB. This way it still gets saved to the DB + name & symbol remain correct.
The text was updated successfully, but these errors were encountered: