Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base token attributes are incorrect after 800A contract update #335

Open
Romsters opened this issue Nov 28, 2024 · 1 comment
Open

Base token attributes are incorrect after 800A contract update #335

Romsters opened this issue Nov 28, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Romsters
Copy link
Collaborator

Romsters commented Nov 28, 2024

🐛 Bug Report

📝 Description

If there is no base token in explorer DB it gets it from config. Token gets added to the DB after token contract deployment event. For base token name and symbol are hardcoded to ETH on a contract level so when contract deployment event is indexed the token gets created in the DB with incorrect ETH name and symbol.

🔄 Reproduction Steps

  • set up custom base token chain;
  • update 800A contract to trigger deployment event;
  • notice base token name and symbol are changed to ETH;

🤔 Expected Behavior

Base token name and symbol should either be taken from config or from L1.

😯 Current Behavior

Base token name and symbol are set to ETH after 800A contract deployment event.

Suggested solution:

Always use name and symbol from config when saving base token to the DB. This way it still gets saved to the DB + name & symbol remain correct.

@Romsters Romsters added the bug Something isn't working label Nov 28, 2024
@Romsters Romsters assigned Romsters and unassigned Romsters Nov 28, 2024
@petarTxFusion petarTxFusion self-assigned this Dec 3, 2024
@petarTxFusion
Copy link
Contributor

We could not reproduce this issue. If base token is declared in api config it shows correct name when you use it, only problem that we found is when sending ETH on non ETH chain that token is displayed as unknown. Maybe we can include that inside of this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants