Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_basic_auth() function #5

Open
chriscrabtree opened this issue Jul 29, 2018 · 1 comment
Open

Add with_basic_auth() function #5

chriscrabtree opened this issue Jul 29, 2018 · 1 comment

Comments

@chriscrabtree
Copy link

First, I really like the design of this: feels idiomatic, extensible, and explicit.

Anyway, I added this with_basic_auth() in my own client code at first, but thought it would be more naturally at home as part of this package. Happy to submit a PR if you like (and if you don't mind dealing with a first-time open-source contributor).

This is the shape of it:
def with_basic_auth(request = %HttpRequest{}, username, password) when is_binary(username) and is_binary(password) do...

Thanks!

@matthewoden
Copy link
Owner

Hey! I just saw this - I think my notification settings are borked. This would be a great addition.

I'm a little swamped, so I'd be delighted to take a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants