Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 support #162

Open
jeevcat opened this issue Jun 29, 2017 · 29 comments
Open

Bootstrap 4 support #162

jeevcat opened this issue Jun 29, 2017 · 29 comments

Comments

@jeevcat
Copy link

jeevcat commented Jun 29, 2017

Is there an easy way to switch over to Bootstrap 4, while using this extension? I understand it's still in Alpha, but I figured it might be something other people might also be interested in.

@mbr
Copy link
Owner

mbr commented Jun 29, 2017 via email

@jeevcat
Copy link
Author

jeevcat commented Jun 30, 2017

Okay thanks for the reply.

I've forked the repo and managed to get v4.0.0-Alpha.6 working. I had to include Tether.js which is required by Bootstrap 4 for tooltips apparently. I also had to fiddle a little with the versioning regex due to the -alpha-style version numbers.

@cofinley
Copy link

cofinley commented Jul 2, 2017

@jeevcat If you have something that works, I'd love to check it out on your fork once you push it.

@jeevcat
Copy link
Author

jeevcat commented Jul 2, 2017

I actually already pushed it 2 days ago. Check it out here: https://github.com/jeevcat/flask-bootstrap-4-alpha.

Please let me know if it works for you.

@cofinley
Copy link

cofinley commented Jul 7, 2017

I was mainly looking for updated wtforms. This is a step in the right direction though. I've updated the forms part on my clone, but kind of towards a side project which may not fall in line with the styling here. Thank you again.

@OverlordQ
Copy link

OverlordQ commented Jul 12, 2017

Yeah, the main issue I've found is the WTForms macros will need a heavy overhaul for v4 forms. Otherwise @jeevcat's fork is WFM.

@beenje
Copy link

beenje commented Aug 3, 2017

I'll try to make a proper pull request starting from @jeevcat repository.

@beenje
Copy link

beenje commented Aug 7, 2017

I just created the pull request #164

@MelleB
Copy link

MelleB commented Apr 10, 2018

What do we need to push this forward?

@mbr
Copy link
Owner

mbr commented Apr 10, 2018 via email

@mbr
Copy link
Owner

mbr commented Apr 10, 2018 via email

@cofinley
Copy link

Recent bug I found with the 4.0 branch is that pagination.html needs the appropriate .page-link and .page-item classes.

@mcnullity
Copy link

Eagerly waiting...

@joncutrer
Copy link

+1

@slidenerd
Copy link

Bootstrap 4 has moved well into the beta version guys, any updates on this?

@zgoda
Copy link

zgoda commented May 30, 2018

B4 left beta back in January, now it's at 4.1.1.

@greyli
Copy link
Contributor

greyli commented Jul 1, 2018

For people who interested, I am maintaining Bootstrap-Flask that based on Flask-Bootstrap and support Bootstrap 4.

@louisguitton
Copy link

Would love to see this as well, as I'm using cards for example.

@jaikumarm
Copy link

+1

1 similar comment
@joaqo
Copy link

joaqo commented Feb 10, 2019

+1

@hfilimonescu
Copy link

hfilimonescu commented Mar 26, 2019

Hi Marc,
I was wondering why all this trouble with dominate? WTForms generate the html with __call__. Am I missing something?

I ask because I might be prepared to do some work on this issue, but first I need to understand the choices and restrictions.

Best regards

@yurzo
Copy link

yurzo commented Mar 31, 2019

Same here, I'm new to Bootstrap and Flask yet the docs and ideas behind flask-bootstrap are gorgeous so I'm interested in seeing it move forward

@mpounsett
Copy link

It's been 2 years since the last commit to this repo, and over a year since (it seems like) @jeevcat 's patch was finalized. Given the lack of activity, should we assume that this project is dead?

I really want to move my Flask projects to Bootstrap 4, but would like to avoid refactoring everything twice. If I move to some other solution and then this package comes back to life and I need to move back, that's going to be irritating.

@bartkamphorst
Copy link

Ping @mbr. Would also love for bootstrap 4 to be supported. Thanks in advance!

@ghost
Copy link

ghost commented Oct 15, 2019

Likewise ping @mbr. Really looking to move to bootstrap 4 (including with WTF) so be good to know if this is imminent or whether I should roll my own. TIA!

@bartkamphorst
Copy link

@mbr Any updates regarding bootstrap 4 support?

@hfilimonescu
Copy link

@bartkamphorst I have made a new package witg Bootstrap 4, based on Flask-Bootstrap.
If you want, you can give it a spin. Flask-BS4

@maxtrem
Copy link

maxtrem commented Jun 2, 2020

This issue has been open now for 3 years. Seems to be quite dead.

on 10 Apr 2018:
I will be looking into this on Sunday.

Will there still be a version for bootstrap 4?

@mpounsett
Copy link

@mbr Maybe it's time to find a new maintainer for this project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests